]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
wifi: iwlegacy: add missing mutex protection in il4965_store_tx_power()
authorZiyi Guo <n7l8m4@u.northwestern.edu>
Sun, 25 Jan 2026 19:40:39 +0000 (19:40 +0000)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 27 Jan 2026 12:52:04 +0000 (13:52 +0100)
commite31fa691d0b1c07b6094a6cf0cce894192c462b3
treeeebf453a45cde18230c9381d466cc7d4d8156b02
parent4dd1dda65265ecbc9f43ffc08e333684cf715152
wifi: iwlegacy: add missing mutex protection in il4965_store_tx_power()

il4965_store_tx_power() calls il_set_tx_power() without holding il->mutex.
However, il_set_tx_power() has lockdep_assert_held(&il->mutex) indicating
that callers must hold this lock.

All other callers of il_set_tx_power() properly acquire the mutex:
- il_bg_scan_completed() acquires mutex at common.c:1683
- il_mac_config() acquires mutex at common.c:5006
- il3945_commit_rxon() and il4965_commit_rxon() are called via work
  queues that hold the mutex (like il4965_bg_alive_start)

Add mutex_lock()/mutex_unlock() around the il_set_tx_power() call in
the sysfs store function to fix the missing lock protection.

Signed-off-by: Ziyi Guo <n7l8m4@u.northwestern.edu>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Link: https://patch.msgid.link/20260125194039.1196488-1-n7l8m4@u.northwestern.edu
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlegacy/4965-mac.c