]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ceph: remove bogus checks and WARN_ONs from ceph_set_page_dirty
authorJeff Layton <jlayton@kernel.org>
Tue, 4 May 2021 14:08:30 +0000 (10:08 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:22:42 +0000 (16:22 +0200)
commite33699d9f441c40aa1d97c60f863d4f8655ebe8f
tree94c4401ee449f4c597b2443a550efc92f33f910b
parent58606882ad8ec6c39e0f40344b922921ef94ab4d
ceph: remove bogus checks and WARN_ONs from ceph_set_page_dirty

[ Upstream commit 22d41cdcd3cfd467a4af074165357fcbea1c37f5 ]

The checks for page->mapping are odd, as set_page_dirty is an
address_space operation, and I don't see where it would be called on a
non-pagecache page.

The warning about the page lock also seems bogus.  The comment over
set_page_dirty() says that it can be called without the page lock in
some rare cases. I don't think we want to warn if that's the case.

Reported-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ceph/addr.c