]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix pgbench performance issue induced by commit af35fe501.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 7 Feb 2025 18:41:42 +0000 (13:41 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 7 Feb 2025 18:41:42 +0000 (13:41 -0500)
commite35d396ec3546cdfdb452ac520cc9384df0bab81
tree20b1e2a64668ad853663056c73673d7b1274e854
parent480acbbd426863fbaddf0606325e9a49e40bd86c
Fix pgbench performance issue induced by commit af35fe501.

Commit af35fe501 caused "pgbench -i" to emit a '\r' character
for each data row loaded (when stderr is a terminal).
That's effectively invisible on-screen, but it causes the
connected terminal program to consume a lot of cycles.
It's even worse if you're connected over ssh, as the data
then has to pass through the ssh tunnel.

Simplest fix is to move the added logic inside the if-tests
that check whether to print a progress line.  We could do
it another way that avoids duplicating these few lines,
but on the whole this seems the most transparent way to
write it.

Like the previous commit, back-patch to all supported versions.

Reported-by: Andres Freund <andres@anarazel.de>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://postgr.es/m/4k4drkh7bcmdezq6zbkhp25mnrzpswqi2o75d5uv2eeg3aq6q7@b7kqdmzzwzgb
Backpatch-through: 13
src/bin/pgbench/pgbench.c