]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: airoha: Fix dev->dsa_ptr check in airoha_get_dsa_tag()
authorLorenzo Bianconi <lorenzo@kernel.org>
Thu, 6 Mar 2025 10:52:20 +0000 (11:52 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Mar 2025 03:40:23 +0000 (19:40 -0800)
commite368d2a1e8b6f0926e4e76a56b484249905192f5
tree4542b33dda8a51d62121414048af2593bc7acab2
parent530581047d32d2f2c92187a467806a8d629f5356
net: airoha: Fix dev->dsa_ptr check in airoha_get_dsa_tag()

Fix the following warning reported by Smatch static checker in
airoha_get_dsa_tag routine:

drivers/net/ethernet/airoha/airoha_eth.c:1722 airoha_get_dsa_tag()
warn: 'dp' isn't an ERR_PTR

dev->dsa_ptr can't be set to an error pointer, it can just be NULL.
Remove this check since it is already performed in netdev_uses_dsa().

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/netdev/Z8l3E0lGOcrel07C@lore-desk/T/#m54adc113fcdd8c5e6c5f65ffd60d8e8b1d483d90
Fixes: af3cf757d5c9 ("net: airoha: Move DSA tag in DMA descriptor")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250306-airoha-flowtable-fixes-v1-1-68d3c1296cdd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/airoha/airoha_eth.c