]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/ttm: Reorder sys manager cleanup step
authorKarolina Stolarek <karolina.stolarek@intel.com>
Mon, 16 Oct 2023 12:15:25 +0000 (14:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Nov 2023 16:26:47 +0000 (17:26 +0100)
commite39440c3268b11c6a496ff9f59758efde72e0769
treee9e1e0723eeacbdc0f46f1d96d1d4ac0f001c828
parentaade33d3d9bb9758e0f06d99132ac95c67f0da62
drm/ttm: Reorder sys manager cleanup step

[ Upstream commit 3b401e30c249849d803de6c332dad2a595a58658 ]

With the current cleanup flow, we could trigger a NULL pointer
dereference if there is a delayed destruction of a BO with a
system resource that gets executed on drain_workqueue() call,
as we attempt to free a resource using an already released
resource manager.

Remove the device from the device list and drain its workqueue
before releasing the system domain manager in ttm_device_fini().

Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231016121525.2237838-1-karolina.stolarek@intel.com
Signed-off-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/ttm/ttm_device.c