]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vsock/virtio: update credit only if socket is not closed
authorStefano Garzarella <sgarzare@redhat.com>
Mon, 8 Feb 2021 14:44:54 +0000 (15:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Feb 2021 13:00:32 +0000 (14:00 +0100)
commite3bb32acc6f51fe0c41513e7ca1f4baba92f8fb7
treec5eaea88c839fea5da29bd6cf1c73be5982a168a
parent8d403a809c8f3e0dda2c1ff22d3ffad015349b02
vsock/virtio: update credit only if socket is not closed

commit ce7536bc7398e2ae552d2fabb7e0e371a9f1fe46 upstream.

If the socket is closed or is being released, some resources used by
virtio_transport_space_update() such as 'vsk->trans' may be released.

To avoid a use after free bug we should only update the available credit
when we are sure the socket is still open and we have the lock held.

Fixes: 06a8fc78367d ("VSOCK: Introduce virtio_vsock_common.ko")
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Link: https://lore.kernel.org/r/20210208144454.84438-1-sgarzare@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/vmw_vsock/virtio_transport_common.c