]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Make firmware parsing failures non-fatal
authorAndrea Bolognani <abologna@redhat.com>
Thu, 29 Feb 2024 14:43:45 +0000 (15:43 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Mon, 4 Mar 2024 13:36:39 +0000 (14:36 +0100)
commite4abb5f0fd9d5f5eb38046cacf64a5400596d26a
tree34bedda0260a1beda485d3dac131356592b3fd67
parente0438b2e80fd64f88c63084cc7a6e6986a0af1d5
qemu: Make firmware parsing failures non-fatal

At the moment, any kind of issue being detected in any of the
firmware descriptor files will result in the entire process
being aborted.

In particular, installing a build of edk2 for an architecture
that libvirt doesn't yet know about, for example loongarch64,
will break most firmware-related functionality: it will no
longer be possible to define new EFI VMs, start existing ones,
or even just obtain the domcapabilities for any architecture.

This is obviously unnecessarily harsh. Adopt a more relaxed
approach and simply ignore the firmware descriptors that we
are unable to parse correctly.

https://bugzilla.redhat.com/show_bug.cgi?id=2258946

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_firmware.c