]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: ethernet: mtk_eth_soc: fix supported_interface set after phylink_create
authorChristian Marangi <ansuelsmth@gmail.com>
Mon, 15 Jun 2026 15:11:00 +0000 (17:11 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 17 Jun 2026 23:05:56 +0000 (16:05 -0700)
commite4b4d8410c7ccea25f4b332a077c6b9f5d263228
tree94d75e3618a3b20d5a12a07d68b0afae4ed92971
parent0e80602c026b98ec9f775f8a6a4eaea577733d6b
net: ethernet: mtk_eth_soc: fix supported_interface set after phylink_create

Everything configured in phylink_config it's assumed to be set before
calling phylink_create() to permit correct parsing of all the different
modes and capabilities.

Commit 51cf06ddafc9 ("net: ethernet: mtk_eth_soc: add support for MT7988
internal 2.5G PHY") while introducing support for 2.5G phy for MT7988,
probably due to an auto-rebase, placed the configuration of the INTERNAL
interface mode for the supported_interfaces for phylink_config right after
phylink_create() introducing a possible problem with supported interfaces
parsing.

While this doesn't currently create any problem/bug, move setting this bit
before phylink_create() to prevent any possible regression in future code
change in phylink core.

Fixes: 51cf06ddafc9 ("net: ethernet: mtk_eth_soc: add support for MT7988 internal 2.5G PHY")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
Link: https://patch.msgid.link/20260615151106.15438-1-ansuelsmth@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mediatek/mtk_eth_soc.c