]> git.ipfire.org Git - thirdparty/gcc.git/commit
ipa-devirt: Fix crash in obj_type_ref_class [PR95114]
authorRichard Sandiford <richard.sandiford@arm.com>
Fri, 7 Aug 2020 09:39:38 +0000 (10:39 +0100)
committerRichard Sandiford <richard.sandiford@arm.com>
Fri, 7 Aug 2020 09:39:38 +0000 (10:39 +0100)
commite4c68cc7dcb6617740ee26f359a34c37c6981685
tree707cc24c0c0dd6a9fcb5dee4fff5700503386766
parent13dc9bf3a88627838c6d27dcb912adac938eb345
ipa-devirt: Fix crash in obj_type_ref_class [PR95114]

The testcase has failed since r9-5035, because obj_type_ref_class
tries to look up an ODR type when no ODR type information is
available.  (The information was available earlier in the
compilation, but was freed during pass_ipa_free_lang_data.)
We then crash dereferencing the null get_odr_type result.

The test passes with -O2.  However, it fails again if -fdump-tree-all
is used, since obj_type_ref_class is called indirectly from the
dump routines.

Other code creates ODR type entries on the fly by passing “true”
as the insert parameter.  But obj_type_ref_class can't do that
unconditionally, since it should have no side-effects when used
from the dumping code.

Following a suggestion from Honza, this patch adds parameters
to say whether the routines are being called from dump routines
and uses those to derive the insert parameter.

gcc/
PR middle-end/95114
* tree.h (virtual_method_call_p): Add a default-false parameter
that indicates whether the function is being called from dump
routines.
(obj_type_ref_class): Likewise.
* tree.c (virtual_method_call_p): Likewise.
* ipa-devirt.c (obj_type_ref_class): Likewise.  Lazily add ODR
type information for the type when the parameter is false.
* tree-pretty-print.c (dump_generic_node): Update calls to
virtual_method_call_p and obj_type_ref_class accordingly.

gcc/testsuite/
PR middle-end/95114
* g++.target/aarch64/pr95114.C: New test.

(cherry picked from commit 5834e96a08fd8b86a42428f38a95903d2f1de202)
gcc/ipa-devirt.c
gcc/testsuite/g++.target/aarch64/pr95114.C [new file with mode: 0644]
gcc/tree-pretty-print.c
gcc/tree.c
gcc/tree.h