]> git.ipfire.org Git - thirdparty/git.git/commit
load_branch_decorations: fix memory leak with non-static filters
authorNicolas Guichard <nicolas@guichard.eu>
Wed, 9 Oct 2024 07:58:18 +0000 (07:58 +0000)
committerJunio C Hamano <gitster@pobox.com>
Wed, 9 Oct 2024 17:52:44 +0000 (10:52 -0700)
commite4d03b79386e3bd0dba1c8096f8602490bda99d6
tree68f02a74edb7e46caa3aa81c6532639b5960e46f
parent777489f9e09c8d0dd6b12f9d90de6376330577a2
load_branch_decorations: fix memory leak with non-static filters

load_branch_decorations calls normalize_glob_ref on each string of filter's
string_lists. This effectively replaces the potentially non-owning char* of
those items with an owning char*.

Set the strdup_string flag on those string_lists.

This was not caught until now because:
- when passing string_lists already with the strdup_string already set, the
  behaviour was correct
- when passing static string_lists, the new char* remain reachable until
  program exit

Signed-off-by: Nicolas Guichard <nicolas@guichard.eu>
Acked-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
log-tree.c