]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
USB: storage: ums-realtek: fix error code in rts51x_read_mem()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 4 Mar 2022 07:35:04 +0000 (10:35 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Apr 2022 12:14:50 +0000 (14:14 +0200)
commite4d788c1f0ad7bc083ab8d6f89becf1d9aa720bf
treef978cae097008b81747e7e4f89969cdf29643807
parent9843c9c98f26c6ad843260b19bfdaa2598f2ae1e
USB: storage: ums-realtek: fix error code in rts51x_read_mem()

[ Upstream commit b07cabb8361dc692522538205552b1b9dab134be ]

The rts51x_read_mem() function should return negative error codes.
Currently if the kmalloc() fails it returns USB_STOR_TRANSPORT_ERROR (3)
which is treated as success by the callers.

Fixes: 065e60964e29 ("ums_realtek: do not use stack memory for DMA")
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220304073504.GA26464@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/storage/realtek_cr.c