]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.
authorAndres Freund <andres@anarazel.de>
Wed, 30 Oct 2019 05:46:40 +0000 (22:46 -0700)
committerAndres Freund <andres@anarazel.de>
Wed, 30 Oct 2019 05:53:05 +0000 (22:53 -0700)
commite4d92126fda1defd9be201b97b162d1568122064
tree795d820d22e308181536ef8f21c48da3319aae0d
parente0f76f204ccb870fc207546eaeae65abeacb7dad
pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.

The additional newline seems to have accidentally been introduced in
2c03216d831, in 9.5. The newline is only issued when an FPW is
present for the block reference.

While there could be an argument that removing the newlines in the
back branches could cause a problem for somebody parsing the
pg_waldump output, the likelihood of that seems small enough. It seems
at least equally likely that the randomness of when newlines are
issued causes problems.

Author: Andres Freund
Discussion: https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.de
Backpatch: 9.5, like 2c03216d831.
src/bin/pg_waldump/pg_waldump.c