]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
xen/netfront: don't trust the backend response data blindly
authorJuergen Gross <jgross@suse.com>
Mon, 29 Nov 2021 09:44:30 +0000 (10:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Dec 2021 08:27:44 +0000 (09:27 +0100)
commite4e01b0e4b7fca40586639647f83eaa21a0a8203
tree9cb1d6aefe94cae5355c929470587676a8bc8353
parente52c0efbd23ca50e4afa76e6ec3c8c83b032c823
xen/netfront: don't trust the backend response data blindly

commit a884daa61a7d91650987e855464526aef219590f upstream.

Today netfront will trust the backend to send only sane response data.
In order to avoid privilege escalations or crashes in case of malicious
backends verify the data to be within expected limits. Especially make
sure that the response always references an outstanding request.

Note that only the tx queue needs special id handling, as for the rx
queue the id is equal to the index in the ring page.

Introduce a new indicator for the device whether it is broken and let
the device stop working when it is set. Set this indicator in case the
backend sets any weird data.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/xen-netfront.c