]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cdc-acm: do not reset notification buffer index upon urb unlinking
authorTobias Herzog <t-herzog@gmx.de>
Sat, 22 Sep 2018 20:11:10 +0000 (22:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 10 Nov 2018 15:49:46 +0000 (07:49 -0800)
commite4e6a27f3786c39a163f9620d90546ecfb102e36
treebba8e2c89bb523acc1d6adf5aa80fcd060bfcb2a
parent1d375e3b466375708742b7635e12c15f87c51a2e
cdc-acm: do not reset notification buffer index upon urb unlinking

commit dae3ddba36f8c337fb59cef07d564da6fc9b7551 upstream.

Resetting the write index of the notification buffer on urb unlink (e.g.
closing a cdc-acm device from userspace) may lead to wrong interpretation
of further received notifications, in case the index is not 0 when urb
unlink happens (i.e. when parts of a notification already have been
transferred). On the device side there is no "reset" of the notification
transimission and thus we would get out of sync with the device.

Signed-off-by: Tobias Herzog <t-herzog@gmx.de>
Acked-by: Oliver Neukum <oneukum@suse.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/cdc-acm.c