]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
smb: client: fix potential NULL deref in parse_dfs_referrals()
authorPaulo Alcantara <pc@manguebit.com>
Wed, 6 Dec 2023 00:49:29 +0000 (21:49 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Dec 2023 17:36:50 +0000 (18:36 +0100)
commite5071ae7d829966fb8345d283efad8e3d5372f16
tree41baa9f32d0aff601b4860ecfd3edb1d864e6220
parentd2bafe84dd7a7d1495b42a9407e05555fbd65f16
smb: client: fix potential NULL deref in parse_dfs_referrals()

[ Upstream commit 92414333eb375ed64f4ae92d34d579e826936480 ]

If server returned no data for FSCTL_DFS_GET_REFERRALS, @dfs_rsp will
remain NULL and then parse_dfs_referrals() will dereference it.

Fix this by returning -EIO when no output data is returned.

Besides, we can't fix it in SMB2_ioctl() as some FSCTLs are allowed to
return no data as per MS-SMB2 2.2.32.

Fixes: 9d49640a21bf ("CIFS: implement get_dfs_refer for SMB2+")
Cc: stable@vger.kernel.org
Reported-by: Robert Morris <rtm@csail.mit.edu>
Signed-off-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/cifs/smb2ops.c