]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtc: pcf85063: fix potential OOB write in PCF85063 NVMEM read
authorOleksij Rempel <o.rempel@pengutronix.de>
Wed, 18 Dec 2024 19:34:58 +0000 (20:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:50:11 +0000 (12:50 +0100)
commite5536677da803ed54a29a446515c28dce7d3d574
tree826bef77966e37b4e18d5582fc8d235c3c847eab
parent2943af7d72d76add59732267f720d4155d38cffc
rtc: pcf85063: fix potential OOB write in PCF85063 NVMEM read

[ Upstream commit 3ab8c5ed4f84fa20cd16794fe8dc31f633fbc70c ]

The nvmem interface supports variable buffer sizes, while the regmap
interface operates with fixed-size storage. If an nvmem client uses a
buffer size less than 4 bytes, regmap_read will write out of bounds
as it expects the buffer to point at an unsigned int.

Fix this by using an intermediary unsigned int to hold the value.

Fixes: fadfd092ee91 ("rtc: pcf85063: add nvram support")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Link: https://lore.kernel.org/r/20241218-rtc-pcf85063-stack-corruption-v1-1-12fd0ee0f046@pengutronix.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-pcf85063.c