]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bridge: fix race with topology change timer
authorstephen hemminger <stephen@networkplumber.org>
Thu, 2 May 2013 14:23:28 +0000 (14:23 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 30 May 2013 13:35:12 +0000 (14:35 +0100)
commite55ab1122b0077d494bd6576513d4952e17bc3ce
tree944ca8cfcc5918479a50cd542099270c62a79f2a
parentfa83b862b34e82d8cbcc1d40889a8d6dd5d56e25
bridge: fix race with topology change timer

[ Upstream commit 83401eb4990ff6af55aeed8f49681558544192e6 ]

A bridge should only send topology change notice if it is not
the root bridge. It is possible for message age timer to elect itself
as a new root bridge, and still have a topology change timer running
but waiting for bridge lock on other CPU.

Solve the race by checking if we are root bridge before continuing.
This was the root cause of the cases where br_send_tcn_bpdu would OOPS.

Reported-by: JerryKang <jerry.kang@samsung.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/bridge/br_stp_timer.c