]> git.ipfire.org Git - thirdparty/gcc.git/commit
tree-optimization/96920 - another ICE when vectorizing nested cycles
authorRichard Biener <rguenther@suse.de>
Fri, 4 Sep 2020 12:35:39 +0000 (14:35 +0200)
committerRichard Biener <rguenther@suse.de>
Wed, 2 Dec 2020 10:06:42 +0000 (11:06 +0100)
commite563687cf9d3d1278f45aaebd03e0f66531076c9
tree770ff3336a98bd03dd5fddf27222d92f3c1f689b
parent66dd83c8840a9a28f6209922b8abd5783a255207
tree-optimization/96920 - another ICE when vectorizing nested cycles

This refines the previous fix for PR96698 by re-doing how and where
we arrange for setting vectorized cycle PHI backedge values.

2020-09-04  Richard Biener  <rguenther@suse.de>

PR tree-optimization/96698
PR tree-optimization/96920
* tree-vectorizer.h (loop_vec_info::reduc_latch_defs): Remove.
(loop_vec_info::reduc_latch_slp_defs): Likewise.
* tree-vect-stmts.c (vect_transform_stmt): Remove vectorized
cycle PHI latch code.
* tree-vect-loop.c (maybe_set_vectorized_backedge_value): New
helper to set vectorized cycle PHI latch values.
(vect_transform_loop): Walk over all PHIs again after
vectorizing them, calling maybe_set_vectorized_backedge_value.
Call maybe_set_vectorized_backedge_value for each vectorized
stmt.  Remove delayed update code.
* tree-vect-slp.c (vect_analyze_slp_instance): Initialize
SLP instance reduc_phis member.
(vect_schedule_slp): Set vectorized cycle PHI latch values.

* gfortran.dg/vect/pr96920.f90: New testcase.
* gcc.dg/vect/pr96920.c: Likewise.

(cherry picked from commit 46a58c779af3055a4b10b285a1f4be28abe4351c)
gcc/testsuite/gcc.dg/vect/pr96920.c [new file with mode: 0644]
gcc/testsuite/gfortran.dg/vect/pr96920.f90 [new file with mode: 0644]
gcc/tree-vect-loop.c
gcc/tree-vect-slp.c
gcc/tree-vect-stmts.c
gcc/tree-vectorizer.h