]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: remove obsolete WARN_ON(refcount_read(&sk->sk_refcnt) == 1)
authorEric Dumazet <edumazet@google.com>
Tue, 14 Oct 2025 14:06:05 +0000 (14:06 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 16 Oct 2025 00:18:38 +0000 (17:18 -0700)
commite5b670e5439bda09ea7e3dd3dd32edb2f367c0d3
tree27a355d3046bbbf7e8fa3c68a0c74399ef5b04e4
parent378e6523ebb1e80b3955b7675cfe40b07028d085
net: remove obsolete WARN_ON(refcount_read(&sk->sk_refcnt) == 1)

sk->sk_refcnt has been converted to refcount_t in 2017.

__sock_put(sk) being refcount_dec(&sk->sk_refcnt), it will complain
loudly if the current refcnt is 1 (or less) in a non racy way.

We can remove four WARN_ON() in favor of the generic refcount_dec()
check.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: Xuanqiang Luo<luoxuanqiang@kylinos.cn>
Link: https://patch.msgid.link/20251014140605.2982703-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/sock.h
net/netlink/af_netlink.c
net/tipc/socket.c