]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: dapm-graph: set fill colour of turned on nodes
authorNicolas Frattaroli <nicolas.frattaroli@collabora.com>
Fri, 21 Feb 2025 20:39:32 +0000 (21:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Mar 2025 19:54:20 +0000 (12:54 -0700)
commite5c9f8d2202d998ca0387cce90fa4242d07da7cc
tree2ccc85fcc38a6837f081d8f438156a956f5f511d
parentdf2ae00d960593014b8bdb0811d06a4b9c920553
ASoC: dapm-graph: set fill colour of turned on nodes

[ Upstream commit d31babd7e304d3b800d36ff74be6739405b985f2 ]

Some tools like KGraphViewer interpret the "ON" nodes not having an
explicitly set fill colour as them being entirely black, which obscures
the text on them and looks funny. In fact, I thought they were off for
the longest time. Comparing to the output of the `dot` tool, I assume
they are supposed to be white.

Instead of speclawyering over who's in the wrong and must immediately
atone for their wickedness at the altar of RFC2119, just be explicit
about it, set the fillcolor to white, and nobody gets confused.

Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://patch.msgid.link/20250221-dapm-graph-node-colour-v1-1-514ed0aa7069@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/sound/dapm-graph