]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
i3c: master: mipi-i3c-hci: Fix a kernel panic for accessing DAT_data.
authorBilly Tsai <billy_tsai@aspeedtech.com>
Mon, 23 Oct 2023 08:02:37 +0000 (16:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Nov 2023 17:07:02 +0000 (17:07 +0000)
commite64d23dc65810be4e3395d72df0c398f60c991f9
tree6f26fc05b2b04381f1e310f96463d3d0d3531b6f
parent472bd4787406bef2e8b41ee4c74d960a06a49a48
i3c: master: mipi-i3c-hci: Fix a kernel panic for accessing DAT_data.

[ Upstream commit b53e9758a31c683fc8615df930262192ed5f034b ]

The `i3c_master_bus_init` function may attach the I2C devices before the
I3C bus initialization. In this flow, the DAT `alloc_entry`` will be used
before the DAT `init`. Additionally, if the `i3c_master_bus_init` fails,
the DAT `cleanup` will execute before the device is detached, which will
execue DAT `free_entry` function. The above scenario can cause the driver
to use DAT_data when it is NULL.

Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Link: https://lore.kernel.org/r/20231023080237.560936-1-billy_tsai@aspeedtech.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i3c/master/mipi-i3c-hci/dat_v1.c