]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
[gdbsupport] Add gdb::array_view::{iterator,const_iterator}
authorTom de Vries <tdevries@suse.de>
Sat, 19 Oct 2024 06:10:38 +0000 (08:10 +0200)
committerTom de Vries <tdevries@suse.de>
Sat, 19 Oct 2024 06:10:38 +0000 (08:10 +0200)
commite686338105177046975bcff8fe6199536e80caf9
treed45b762e839f333832bcc6916b3139ba63af3cfd
parent6c8052f6b22fbb6ae1edc759454626d465ee317c
[gdbsupport] Add gdb::array_view::{iterator,const_iterator}

While trying to substitute some std::vector type A in the code with a
gdb::array_view:
...
- using A = std::vector<T>
+ using A = gdb::array_view<T>
....
I ran into the problem that the code was using A::iterator while
gdb::array_view doesn't define such a type.

Fix this by:
- adding types gdb::array_view::iterator and gdb::array_view::const_iterator,
- using them in gdb::array_view::(c)begin and gdb::array_view::(c)end, as is
  usual, and
- using them explicitly in a unit test.

Tested on aarch64-linux.

Approved-By: Tom Tromey <tom@tromey.com>
gdb/unittests/array-view-selftests.c
gdbsupport/array-view.h