]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/i915/display: Take into account AS SDP in intel_dp_sdp_min_guardband
authorJouni Högander <jouni.hogander@intel.com>
Thu, 23 Oct 2025 04:31:40 +0000 (07:31 +0300)
committerJouni Högander <jouni.hogander@intel.com>
Thu, 30 Oct 2025 13:03:58 +0000 (15:03 +0200)
commite69b7a6bd4ea813282956873b63f8215f73ed966
treee700b97fd3ae2c08cf546d4074f83e977b173486
parent06a691f0e7d08fb52a6020bd5b1f1f9cd091aaae
drm/i915/display: Take into account AS SDP in intel_dp_sdp_min_guardband

We started seeing "[drm] *ERROR* Timed out waiting PSR idle state" after
taking optimized guardband into use. These are seen because VSC SDPs are
sent on same line as AS SDPs when AS SDP is enabled. AS SDP is sent on line
configured in EMP_AS_SDP_TL register. We are configuring
crtc_state->vrr.vsync_start into that register.

Fix this by ensuring AS SDP is sent on line which is within
guardband. From the bspec:

EMP_AS_SDP_TL < SCL + Guardband

v2: check HAS_AS_SDP

Bspec: 71197
Fixes: 52ecd48b8d3f ("drm/i915/dp: Add helper to get min sdp guardband")
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://lore.kernel.org/r/20251023043140.961104-1-jouni.hogander@intel.com
drivers/gpu/drm/i915/display/intel_dp.c