]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Remove capng_lock() call when spawning LXC container init process
authorDaniel P. Berrange <berrange@redhat.com>
Thu, 12 Nov 2009 11:03:23 +0000 (11:03 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Fri, 13 Nov 2009 11:50:05 +0000 (11:50 +0000)
commite6cbadd588482930ba13e2f592200ff9b9d4455f
treec7c2fa9a5de6d7be46ceba9b99834054882d16e9
parentce62916b6ed09f63ea336483cfe9e8d5ae87736e
Remove capng_lock() call when spawning LXC container init process

The capng_lock() call sets the SECURE_NO_SETUID_FIXUP and SECURE_NOROOT
bits on the process. This prevents the kernel granting capabilities to
processes with an effective UID of 0, or with setuid programs. This is
not actually what we want in the container init process. It should be
allowed to run setuid processes & keep capabilities when root. All that
is required is masking a handful of dangerous capabilities from the
bounding set.

* src/lxc/lxc_container.c: Remove bogus capng_lock() call.
src/lxc/lxc_container.c