]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
greybus: gb-beagleplay: Fix timeout handling in bootloader functions
authorHaotian Zhang <vulab@iscas.ac.cn>
Fri, 21 Nov 2025 06:40:27 +0000 (14:40 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Nov 2025 13:40:59 +0000 (14:40 +0100)
commite6df0f649cff08da7a2feb6d963b39076ca129f9
treeedc7f8a2241211029803afe1ce837f950598d35c
parent8c5d9488b9c0e07dc648d9dfceeed6ad068daba2
greybus: gb-beagleplay: Fix timeout handling in bootloader functions

wait_for_completion_timeout() returns the remaining jiffies
(at least 1) on success or 0 on timeout, but never negative
error codes. The current code incorrectly checks for negative
values, causing timeouts to be ignored and treated as success.

Check for a zero return value to correctly identify and
handle timeout events.

Fixes: 0cf7befa3ea2 ("greybus: gb-beagleplay: Add firmware upload API")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251121064027.571-1-vulab@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/greybus/gb-beagleplay.c