]> git.ipfire.org Git - thirdparty/libvirt.git/commit
storage: Fix build issue with MOUNT and VGCHANGE commands
authorJohn Ferlan <jferlan@redhat.com>
Thu, 13 Dec 2018 16:11:18 +0000 (11:11 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Thu, 13 Dec 2018 17:42:36 +0000 (12:42 -0500)
commite6f53e7a4b43eab35e71bc95596d03809079ac45
tree048a68c3596cf870555ee414448782237d0c05fe
parentfe2bd0210e80c94513291c7db927697bf5e7841b
storage: Fix build issue with MOUNT and VGCHANGE commands

Turns out there some build platforms that must not define MOUNT
or VGCHANGE in config.h... So moving the commands from the storage
backend specific module into a common storage_util module causes
issues for those platforms.

So instead of assuming they are there, let's just pass the command
string to the storage util API's from the storage backend specific
code (as would have been successful before).  Also modify the test
to determine whether the MOUNT and/or VGCHANGE doesn't exist and
just define it to (for example) what Fedora has for the path. Could
have just used "mount" and "vgchange" in the call, but that defeats
the purpose of adding the call to virTestClearCommandPath.

Signed-off-by: John Ferlan <jferlan@redhat.com>
src/storage/storage_backend_fs.c
src/storage/storage_backend_logical.c
src/storage/storage_util.c
src/storage/storage_util.h
tests/storagepoolxml2argvtest.c