]> git.ipfire.org Git - thirdparty/samba.git/commit
s3: smbd: Use separate flag to track become_root()/unbecome_root() state.
authorJeremy Allison <jra@samba.org>
Wed, 17 Jun 2015 17:23:30 +0000 (10:23 -0700)
committerKarolin Seeger <kseeger@samba.org>
Tue, 30 Jun 2015 00:06:28 +0000 (02:06 +0200)
commite700e9d4312a77066b344a763b2f05be7190e257
tree1d352ad7e6c09e3b0669c2d9020d1f1da5c3d83a
parentaf4617aea187d701d1f43cc5faefd0f2302f60f3
s3: smbd: Use separate flag to track become_root()/unbecome_root() state.

Early function exit can mean backup_priv is set but we haven't called
become_root(). *Lots* of work by the reviewers went in to checking this
isn't a security issue.

Found by Codenomicon at the Redmond plugfest.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11339

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jun 25 22:14:58 CEST 2015 on sn-devel-104

(cherry picked from commit e2c4b8967d33b610f9f076c614352e4b8fc7c558)
source3/smbd/trans2.c