]> git.ipfire.org Git - thirdparty/postgresql.git/commit
set_deparse_plan: Reuse variable to appease Coverity
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 20 Apr 2022 09:44:08 +0000 (11:44 +0200)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 20 Apr 2022 09:44:08 +0000 (11:44 +0200)
commite70813fbc4aaca35ec012d5a426706bd54e4acab
tree2f69ca39209038a8048c2b4af7db14687c9f71ed
parenta87e75956926f966d90bdd1a6bd495cf59cdc3ad
set_deparse_plan: Reuse variable to appease Coverity

Coverity complains that dpns->outer_plan is deferenced (to obtain
->targetlist) when possibly NULL.  We can avoid this by using
dpns->outer_tlist instead, which was already obtained a few lines up.

The fact that we end up with
  dpns->inner_tlist = dpns->outer_tlist
is a bit suspicious-looking and maybe worthy of more investigation, but
I'll leave that for another day.

Reviewed-by: Michaƫl Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/202204191345.qerjy3kxi3eb@alvherre.pgsql
src/backend/utils/adt/ruleutils.c