]> git.ipfire.org Git - thirdparty/coreutils.git/commit
mkdir: don't assume umask equals POSIX default ACL mask
authorPaul Eggert <eggert@cs.ucla.edu>
Sun, 12 May 2013 02:17:10 +0000 (19:17 -0700)
committerPaul Eggert <eggert@cs.ucla.edu>
Sun, 12 May 2013 02:22:54 +0000 (19:22 -0700)
commite7198a67b8dd7f23925dfa40b7a90342e185f729
tree783abb446c0b54bb34e1770442e1a5f824904341
parent7b65f8e92888ffe3ea7d0b3824affa1dfc76b8c5
mkdir: don't assume umask equals POSIX default ACL mask

This fixes Bug#14371, reported by Killer Bassist.
* NEWS: Document this.
* src/mkdir.c (struct mkdir_options): Remove member ancestor_mode.
New member umask_value.  All uses changed.
* src/mkdir.c (make_ancestor): Fix umask assumption.
* src/mkdir.c, src/mkfifo.c, src/mknod.c (main):
Leave umask alone.  This requires invoking lchmod after creating
the file, which introduces a race condition, but this can't be
avoided on hosts with "POSIX" default ACLs, and there's no easy
way with network file systems to tell what kind of host the
directory is on.
* tests/local.mk (all_tests): Add tests/mkdir/p-acl.sh.
* tests/mkdir/p-acl.sh: New file.
NEWS
src/mkdir.c
src/mkfifo.c
src/mknod.c
tests/local.mk
tests/mkdir/p-acl.sh [new file with mode: 0755]