]> git.ipfire.org Git - thirdparty/openvpn.git/commit
cleanup: Move init_random_seed() to where it is being used
authorDavid Sommerseth <davids@openvpn.net>
Tue, 25 Jul 2017 15:07:23 +0000 (17:07 +0200)
committerDavid Sommerseth <davids@openvpn.net>
Fri, 11 Aug 2017 19:40:12 +0000 (21:40 +0200)
commite74e3a4db891b3ace0a96461c597d86e87be06f0
tree4f843223831f8ad75ac30677b26ba4e9a46c1927
parent59e7e9fce8de6ea90d13baeaede83adc0b594e22
cleanup: Move init_random_seed() to where it is being used

The init_random_seed() function is only used by the init_static() in
init.c.  As this function was pretty basic and it is only being called
once, it was merged into init_static() instead of keeping it as a separate
function.

(I agree that calling functions often makes the code more readable, but
I would rather see that as a part of cleaning up the whole init_static()
function - in fact when moving all "unit tests" in init_static() to cmocka,
it will not be too bad in the end.)

Signed-off-by: David Sommerseth <davids@openvpn.net>
Acked-by: Steffan Karger <steffan@karger.me>
Message-Id: <20170725150723.14919-1-davids@openvpn.net>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15136.html
Signed-off-by: David Sommerseth <davids@openvpn.net>
src/openvpn/init.c
src/openvpn/misc.c
src/openvpn/misc.h