]> git.ipfire.org Git - thirdparty/libvirt.git/commit
nwfilter: Disallow binding creation in session mode
authorJohn Ferlan <jferlan@redhat.com>
Mon, 27 Aug 2018 14:41:35 +0000 (10:41 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Thu, 6 Sep 2018 22:38:06 +0000 (18:38 -0400)
commite773e1cbbc5a38da7579de4c9c15f9a8e4b7c8d3
tree33215a670d08fcaa6d9355bd52ecc8ce03f08e6b
parent04eb7479fc0d9196e07f7db227deb3a8003e8964
nwfilter: Disallow binding creation in session mode

Similar to nwfilterDefineXML, let's be sure the a filter binding
creation is not attempted in session mode and generate the proper
error message.

Failure to open nwfilter in session mode (nwfilterConnectOpen)
fails already, but that doesn't stop the free thinker from using
a different connection in order to attempt to attempt to create
the binding. Although even doing that would result in a failure:

$ virsh nwfilter-binding-create QEMUGuest1-binding.xml
error: Failed to create network filter from QEMUGuest1-binding.xml
error: internal error: Could not get access to ACL tech driver 'ebiptables'

$

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/nwfilter/nwfilter_driver.c