]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
PCI: endpoint: pci-epf-test: Don't free doorbell IRQ unless requested
authorKoichiro Den <den@valinux.co.jp>
Tue, 17 Feb 2026 06:38:55 +0000 (15:38 +0900)
committerManivannan Sadhasivam <mani@kernel.org>
Tue, 24 Feb 2026 10:23:59 +0000 (15:53 +0530)
commite81fa70179aac6ac3a6636565d5d35968dca3900
tree1ed5eb195abfe3a9b1be0b2478e7309383617062
parentcc04f2bfb9dae60b6e34d6bff75c26d4ec3237ce
PCI: endpoint: pci-epf-test: Don't free doorbell IRQ unless requested

pci_epf_test_doorbell_cleanup() unconditionally calls free_irq() for the
doorbell virq, which can trigger "Trying to free already-free IRQ"
warnings when the IRQ was never requested or when request_threaded_irq()
failed.

Move free_irq() out of pci_epf_test_doorbell_cleanup() and invoke it
only after a successful request, so that free_irq() is not called for
an unrequested IRQ.

Fixes: eff0c286aa91 ("PCI: endpoint: pci-epf-test: Add doorbell test support")
Signed-off-by: Koichiro Den <den@valinux.co.jp>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Link: https://patch.msgid.link/20260217063856.3759713-3-den@valinux.co.jp
drivers/pci/endpoint/functions/pci-epf-test.c