]> git.ipfire.org Git - thirdparty/coreutils.git/commit
tests: use compare-vs-/dev/null instead of 'test -s'
authorBernhard Voelker <mail@bernhard-voelker.de>
Wed, 14 Jan 2015 16:38:12 +0000 (17:38 +0100)
committerBernhard Voelker <mail@bernhard-voelker.de>
Wed, 14 Jan 2015 16:38:12 +0000 (17:38 +0100)
commite84046dbe6dd26bfcea7edf6fb419bea274635ab
tree50160bef015be6a261b0986762e23a449657fe0b
parent58cff8a009ed9b8280c5f35074cef97231286023
tests: use compare-vs-/dev/null instead of 'test -s'

When some program produces unexpected output, that use of
compare-vs-/dev/null will ensure that the surprising output is
printed in the test's output.  With "test -s err" only, one
would have to instrument and rerun in order to see the offending
output.

* cfg.mk (sc_prohibit_and_fail_1): Exempt 'compare' from this check.
* tests/dd/misc.sh: Change "tests -s ... || fail=1" to
"compare /dev/null ... && fail=1".
* tests/misc/nice.sh: Likewise.
* tests/rm/read-only.sh: Likewise.
* tests/tail-2/inotify-race.sh: Likewise.
* tests/touch/no-dereference.sh: Likewise.

Suggested by Jim Meyering in
http://lists.gnu.org/archive/html/coreutils/2015-01/msg00042.html
cfg.mk
tests/dd/misc.sh
tests/misc/nice.sh
tests/rm/read-only.sh
tests/tail-2/inotify-race.sh
tests/touch/no-dereference.sh