]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
char: misc: Use IS_ERR() for filp_open() return value
authorAlper Ak <alperyasinak1@gmail.com>
Fri, 26 Dec 2025 23:02:48 +0000 (02:02 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 29 Dec 2025 10:59:22 +0000 (11:59 +0100)
commite849ada70c6b1ee22e9f4f5c0e38231dcee53f04
tree7093c6d36fb88f33fcb3473b60d9fbdc5593eb45
parentdad9f13d967b4e53e8eaf5f9c690f8e778ad9802
char: misc: Use IS_ERR() for filp_open() return value

filp_open() never returns NULL, it returns either a valid pointer or an
error pointer. Using IS_ERR_OR_NULL() is unnecessary. Additionally, if
filp were NULL, PTR_ERR(NULL) would return 0, leading to a misleading
error message.

Fixes: 74d8361be344 ("char: misc: add test cases")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202506132058.thWZHlrb-lkp@intel.com/
Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Link: https://patch.msgid.link/20251226230248.113073-1-alperyasinak1@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/misc_minor_kunit.c