]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix deadlock at startup, if max_prepared_transactions is too small.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Apr 2015 18:25:44 +0000 (21:25 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Apr 2015 18:36:59 +0000 (21:36 +0300)
commite8528a8f5d411f0d9a1a9f927eae332992949aa1
treea9052fba876ab2daea87cf70eb4870787b932570
parent42f522714e5eea90feb1c2d5d2fe2d6018b1e628
Fix deadlock at startup, if max_prepared_transactions is too small.

When the startup process recovers transactions by scanning pg_twophase
directory, it should clear MyLockedGxact after it's done processing each
transaction. Like we do during normal operation, at PREPARE TRANSACTION.
Otherwise, if the startup process exits due to an error, it will try to
clear the locking_backend field of the last recovered transaction. That's
usually harmless, but if the error happens in MarkAsPreparing, while
holding TwoPhaseStateLock, the shmem-exit hook will try to acquire
TwoPhaseStateLock again, and deadlock with itself.

This fixes bug #13128 reported by Grant McAlister. The bug was introduced
by commit bb38fb0d, so backpatch to all supported versions like that
commit.
src/backend/access/transam/twophase.c