]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cgroup: fix unbalanced locking
authorZefan Li <lizefan@huawei.com>
Thu, 18 Sep 2014 09:28:46 +0000 (17:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 5 Oct 2014 20:41:03 +0000 (13:41 -0700)
commite8c35a7604d19cd4f9b3ff4015faab8acb7b782c
treedf7d554aead9d00f55b530fdf8ea04c144a6c9c6
parent7d73a89ba1408035381e19a0e890a4aaf15d0ec5
cgroup: fix unbalanced locking

commit eb4aec84d6bdf98d00cedb41c18000f7a31e648a upstream.

cgroup_pidlist_start() holds cgrp->pidlist_mutex and then calls
pidlist_array_load(), and cgroup_pidlist_stop() releases the mutex.

It is wrong that we release the mutex in the failure path in
pidlist_array_load(), because cgroup_pidlist_stop() will be called
no matter if cgroup_pidlist_start() returns errno or not.

Fixes: 4bac00d16a8760eae7205e41d2c246477d42a210
Signed-off-by: Zefan Li <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/cgroup.c