]> git.ipfire.org Git - people/ms/linux.git/commit
projects / people / ms / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3bd9d8c) | patch
can: mcp251xfd: mcp251xfd_open(): open_candev() first
authorMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 22 Oct 2021 16:45:05 +0000 (18:45 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sat, 8 Jan 2022 19:17:41 +0000 (20:17 +0100)
commite91aae8efc4eebd33bdebe067ab248c242cc0135
tree352e38b19ee5ced7c55070e7501590622c57157atree
parent3bd9d8ce6f8c5c43ee2f1106021db0f98882cc75commit | diff
can: mcp251xfd: mcp251xfd_open(): open_candev() first

This patch exchanges the order of open_candev() and
pm_runtime_get_sync(), so that open_candev() is called first.

A usual reason why open_candev() fails is missing CAN bit rate
configuration. It makes no sense to resume the device from PM sleep
first just to put it to sleep if the bit rate is not configured.

Link: https://lore.kernel.org/all/20220105154300.1258636-5-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c diff | blob | blame | history
Michael's Linux tree.