]> git.ipfire.org Git - thirdparty/libvirt.git/commit
snapshot: reject transient disks where code is not ready
authorEric Blake <eblake@redhat.com>
Sat, 13 Aug 2011 21:42:48 +0000 (15:42 -0600)
committerEric Blake <eblake@redhat.com>
Mon, 5 Sep 2011 13:03:04 +0000 (07:03 -0600)
commite91d27ee450cd03f273e1e91e0922fe2ce007efc
tree3ad57608d72b56d1b88a8710d353f326678c6007
parent471235307f0de3c05b3508755bcc35949a954e1a
snapshot: reject transient disks where code is not ready

The previous patch introduced new config, but if a hypervisor does
not support that new config, someone can write XML that does not
behave as documented.  This prevents some of those cases by
explicitly rejecting transient disks for several hypervisors.

Disk snapshots will require a new flag to actually affect a snapshot
creation, so there's not much to reject there.

* src/qemu/qemu_command.c (qemuBuildDriveStr): Reject transient
disks for now.
* src/libxl/libxl_conf.c (libxlMakeDisk): Likewise.
* src/xenxs/xen_sxpr.c (xenFormatSxprDisk): Likewise.
* src/xenxs/xen_xm.c (xenFormatXMDisk): Likewise.
src/libxl/libxl_conf.c
src/qemu/qemu_command.c
src/xenxs/xen_sxpr.c
src/xenxs/xen_xm.c