]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fib_rules: Fix dump_rules() not to exit early
authorRoland Dreier <roland@purestorage.com>
Mon, 5 Oct 2015 17:29:28 +0000 (10:29 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Oct 2015 21:37:53 +0000 (14:37 -0700)
commite9346b9a2f5cd4ff470ee58d1bf271d0a2ca27a0
treec16004553a660c9a2ff52e62a9467245d242e4a2
parent495d9de1ad472cd215ac72bcfa8ac6252af02e16
fib_rules: Fix dump_rules() not to exit early

Backports of 41fc014332d9 ("fib_rules: fix fib rule dumps across
multiple skbs") introduced a regression in "ip rule show" - it ends up
dumping the first rule over and over and never exiting, because 3.19
and earlier are missing commit 053c095a82cf ("netlink: make
nlmsg_end() and genlmsg_end() void"), so fib_nl_fill_rule() ends up
returning skb->len (i.e. > 0) in the success case.

Fix this by checking the return code for < 0 instead of != 0.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/core/fib_rules.c