]> git.ipfire.org Git - thirdparty/libvirt.git/commit
tests: fix iptables test case commandline options in virfirewalltest.c
authorLaine Stump <laine@redhat.com>
Tue, 17 Nov 2020 18:51:45 +0000 (13:51 -0500)
committerLaine Stump <laine@redhat.com>
Tue, 24 Nov 2020 19:21:41 +0000 (14:21 -0500)
commite9693502fb63ce5ddd07d2599daddc563c422eed
tree0a49bab9e4dca6a8da325c3aa306937df2891a5d
parent0a867cd895f06134d24eb27070285bb4b50c088f
tests: fix iptables test case commandline options in virfirewalltest.c

This test was created with all the commandlines erroneously having
"--source-host", which is not a valid iptables option. The correct
name for the option is "--source". However, since the test is just
checking that the generated commandline matches what we told it to
generate (and never actually runs iptables, as that would be a "Really
Bad Idea"(tm)), the test has always succeeded. I only found it because
I made a change to the code that caused the test to incorrectly try to
run iptables during the test, and the error message I received was
"odd" (it complained about the bad option, rather than complaining
that I had insufficient privilege to run the command).

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
tests/virfirewalltest.c