]> git.ipfire.org Git - thirdparty/samba.git/commit
s4:torture: Remove test for deprecated WINBINDD_SHOW_SEQUENCE
authorPavel Filipenský <pfilipensky@samba.org>
Mon, 16 Dec 2024 13:12:22 +0000 (14:12 +0100)
committerVolker Lendecke <vl@samba.org>
Tue, 17 Dec 2024 12:30:31 +0000 (12:30 +0000)
commite97fbcc4b1ee79dd15462e9db58886bc38c12ca1
treef65aa55baf3541b1e8cc9107e1334c96816f64b0
parent2e8009b4ca54003c72da52c76e1f2f1b175f2314
s4:torture: Remove test for deprecated WINBINDD_SHOW_SEQUENCE

torture_winbind_struct_show_sequence() is failing if run as:

make -j8 test TESTS="samba4.rpc.lsa.trusted.*ad_dc samba4.winbind.struct.ad_dc"

The reason is that the test constructs two lists of domains and assumes
that the list contain same domains in the same order.

However:

- the list based on DO_STRUCT_REQ_REP(WINBINDD_SHOW_SEQUENCE, &req, &rep) contains 51 domains
- the list based on DO_STRUCT_REQ_REP(WINBINDD_LIST_TRUSTDOM, &req, &rep) contains 39 domains

and we got:

failure: show_sequence [ ../../source4/torture/winbind/struct_based.c:824: domlist[i].netbios_name was TORTURE201, expected TORTURE200: inconsistent order of domain lists
]

Both list are based on full domain list, however the smaller one filters
out domain without trust_type in winbindd_list_trusted_domains():

trust_type = get_trust_type_string(talloc_tos(), d, domain);
if (trust_type == NULL) {
continue;
}

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source4/torture/winbind/struct_based.c