]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: Fix overflow in command-line resource alignment requests
authorColin Ian King <colin.king@canonical.com>
Sat, 14 Nov 2020 21:48:04 +0000 (15:48 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:25:58 +0000 (11:25 +0100)
commite9817c8cf22f750f3547962544d4ae4e5d28c93c
treebdde1f9b7bc4e8ffdca1865103750594a2ab51e4
parent6d7483c6434f1da19b0140bd4d62c7e18a26ffa6
PCI: Fix overflow in command-line resource alignment requests

[ Upstream commit cc73eb321d246776e5a9f7723d15708809aa3699 ]

The shift of 1 by align_order is evaluated using 32 bit arithmetic and the
result is assigned to a resource_size_t type variable that is a 64 bit
unsigned integer on 64 bit platforms. Fix an overflow before widening issue
by making the 1 a ULL.

Addresses-Coverity: ("Unintentional integer overflow")
Fixes: 32a9a682bef2 ("PCI: allow assignment of memory resources with a specified alignment")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/pci.c