]> git.ipfire.org Git - thirdparty/openwrt.git/commit
realtek: pcs: drop PCS creation without SerDes ref
authorJonas Jelonek <jelonek.jonas@gmail.com>
Thu, 11 Dec 2025 22:37:33 +0000 (22:37 +0000)
committerRobert Marko <robimarko@gmail.com>
Tue, 16 Dec 2025 12:38:13 +0000 (13:38 +0100)
commite989bf80a86147acb8444e13db5e298f55a2a728
tree2748ac8e2161c58afd09875aae916aec74acd2f9
parent2e56a1ffc6914d60201fa3fce9b82e089148feb4
realtek: pcs: drop PCS creation without SerDes ref

Since the beginning, the PCS driver had the ability to call its
rtpcs_create without a reference to a valid PCS node. A comment in the
code mentions that this is done for RTL838X and its built-in octa-PHY
which is connected directly instead of via a SerDes. Further
explanations are not provided.

Drop this ability and make the rtpcs_create call in the dsa driver
conditional. As the built-in PHY of RTL838X isn't attached to a SerDes,
there is no obvious point of having the PCS driver in that chain. The
ports are marked as internal and have no pcs-handle, thus no phylink_pcs
instance should be created.

Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/21146
Signed-off-by: Robert Marko <robimarko@gmail.com>
(cherry picked from commit a58e41e522bf5b273fa626e03546b92141731d9c)
target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/common.c
target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c