]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nl80211: fix per-station group key get/del and memory leak
authorJohannes Berg <johannes.berg@intel.com>
Fri, 23 Jan 2015 10:10:12 +0000 (11:10 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Feb 2015 06:35:50 +0000 (22:35 -0800)
commite98f093f513ee393d55232217e0ac6fbaa50bb7a
tree31142c0c277e9756f71b82a932b94b5e500110d7
parenta30f0cb99fbc11053934edaf91233f0d0ebb1b5f
nl80211: fix per-station group key get/del and memory leak

commit 0fa7b39131576dd1baa6ca17fca53c65d7f62249 upstream.

In case userspace attempts to obtain key information for or delete a
unicast key, this is currently erroneously rejected unless the driver
sets the WIPHY_FLAG_IBSS_RSN flag. Apparently enough drivers do so it
was never noticed.

Fix that, and while at it fix a potential memory leak: the error path
in the get_key() function was placed after allocating a message but
didn't free it - move it to a better place. Luckily admin permissions
are needed to call this operation.

Fixes: e31b82136d1ad ("cfg80211/mac80211: allow per-station GTKs")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/wireless/nl80211.c