]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemuhotplugtest: Call qemuDomainUpdateDeviceLive() directly
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 20 Apr 2023 15:47:04 +0000 (17:47 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 25 Apr 2023 06:46:27 +0000 (08:46 +0200)
commite98f0b99c0e00da428cc5475e1c6e2a109b2a638
treeface50c345e28d695e3edaa1897b82b1cba021ed
parentf7b8f740ca9391bb5403bbd0865570925706fa86
qemuhotplugtest: Call qemuDomainUpdateDeviceLive() directly

There's no reason for qemuhotplugtest to reimplement which device
update function to call (testQemuHotplugUpdate()) when
qemuDomainUpdateDeviceLive() already does that. Thus, drop
testQemuHotplugUpdate() and call qemuDomainUpdateDeviceLive()
directly.

BTW: this also shows why reimplementing
qemuDomainUpdateDeviceLive() is bad idea: The
"disk-cdrom-nochange" test is succeeding only because
testQemuHotplugUpdate() supports graphics and returns an
(expected) error for every other devtype.

NB, there's still missing check that the resulting XML is the
expected one (just like we do for attach and detach), but that's
pre-existing and will be fixed later.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
tests/qemuhotplugtest.c