]> git.ipfire.org Git - thirdparty/dbus.git/commit
bus_config_parser_check_doctype: Remove, unused
authorSimon McVittie <smcv@collabora.com>
Wed, 29 Aug 2018 17:33:01 +0000 (18:33 +0100)
committerSimon McVittie <smcv@collabora.com>
Thu, 30 Aug 2018 16:39:38 +0000 (17:39 +0100)
commitea0275aaeadcffffa00a653c81cc7912aa365eae
tree5a0dd7e9f5e8682937dd700c800441883bb5c8eb
parent488ed14cc0842b2947ed6c44e48d4e736449ef2d
bus_config_parser_check_doctype: Remove, unused

We have never checked the <!DOCTYPE> of busconfig XML since the libxml
parser was removed in 2013, and the libxml parser was broken before
that anyway. The recommended Expat parser (our only parser since 2013)
does not appear to have ever validated this, so now does not seem like
the time to start. Just ignore the <!DOCTYPE> if there is one.

(We never validated this particularly strictly anyway;
<!DOCTYPE busconfig SYSTEM "http://example.com/bees"> would have been
treated as perfectly valid.)

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=107739
bus/config-parser-trivial.c
bus/config-parser-trivial.h
bus/config-parser.c
bus/config-parser.h