]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtnetlink: fix userspace API breakage for iproute2 < v3.9.0
authorMichal Schmidt <mschmidt@redhat.com>
Wed, 28 May 2014 12:15:19 +0000 (14:15 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 6 Aug 2014 17:07:39 +0000 (18:07 +0100)
commitea43a736ef5810a2ff1755771cc00c367805b5bf
treefef1d89993289ef2e7f4f7840a32b5e90df5366e
parent223105654ef9efb8c040cfb91e03ce1a8de69dd0
rtnetlink: fix userspace API breakage for iproute2 < v3.9.0

commit e5eca6d41f53db48edd8cf88a3f59d2c30227f8e upstream.

When running RHEL6 userspace on a current upstream kernel, "ip link"
fails to show VF information.

The reason is a kernel<->userspace API change introduced by commit
88c5b5ce5cb57 ("rtnetlink: Call nlmsg_parse() with correct header length"),
after which the kernel does not see iproute2's IFLA_EXT_MASK attribute
in the netlink request.

iproute2 adjusted for the API change in its commit 63338dca4513
("libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter").

The problem has been noticed before:
http://marc.info/?l=linux-netdev&m=136692296022182&w=2
(Subject: Re: getting VF link info seems to be broken in 3.9-rc8)

We can do better than tell those with old userspace to upgrade. We can
recognize the old iproute2 in the kernel by checking the netlink message
length. Even when including the IFLA_EXT_MASK attribute, its netlink
message is shorter than struct ifinfomsg.

With this patch "ip link" shows VF information in both old and new
iproute2 versions.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/core/rtnetlink.c