]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
spi: trigger trace event for message-done before mesg->complete
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 18 Mar 2015 10:27:28 +0000 (11:27 +0100)
committerSasha Levin <sasha.levin@oracle.com>
Fri, 17 Apr 2015 00:13:13 +0000 (20:13 -0400)
commitea4e289c2847a4fbcb140295e3fd60ec5b5c8052
tree17553de70f54aba3e2fe58b86b6fe9499a46d5b9
parent7cc582d4ae5dd15351fdb9cd7e0e34462b09c2f9
spi: trigger trace event for message-done before mesg->complete

[ Upstream commit 391949b6f02121371e3d7d9082c6d17fd9853034 ]

With spidev the mesg->complete callback points to spidev_complete.
Calling this unblocks spidev_sync and so spidev_sync_write finishes. As
the struct spi_message just read is a local variable in
spidev_sync_write and recording the trace event accesses this message
the recording is better done first. The same can happen for
spidev_sync_read.

This fixes an oops observed on a 3.14-rt system with spidev activity
after

echo 1 > /sys/kernel/debug/tracing/events/spi/enable

.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/spi/spi.c