]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging: r8188eu: add error handling of rtw_read8
authorPavel Skripkin <paskripkin@gmail.com>
Tue, 7 Jun 2022 19:26:05 +0000 (22:26 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:45:40 +0000 (11:45 +0200)
commiteac7d9f47ad40fd7530ade2428686bd2f374a849
treeb5cbf8dda4fd5a10002ec181031c98b7c9e9aafd
parent582b3175deeaa052809c95a270629571d8641f66
staging: r8188eu: add error handling of rtw_read8

[ Upstream commit 857fe9e5efc09833fe1110e99d8baba954a86abb ]

rtw_read8() reads data from device via USB API which may fail. In case
of any failure previous code returned stack data to callers, which is
wrong.

Fix it by changing rtw_read8() prototype and prevent caller from
touching random stack data

Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Link: https://lore.kernel.org/r/c8f8ef4f14db3ba2478a87d5be6eb768a093dfaf.1654629778.git.paskripkin@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
16 files changed:
drivers/staging/r8188eu/core/rtw_efuse.c
drivers/staging/r8188eu/core/rtw_fw.c
drivers/staging/r8188eu/core/rtw_led.c
drivers/staging/r8188eu/core/rtw_mlme_ext.c
drivers/staging/r8188eu/core/rtw_wlan_util.c
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c
drivers/staging/r8188eu/hal/hal_com.c
drivers/staging/r8188eu/hal/rtl8188e_cmd.c
drivers/staging/r8188eu/hal/rtl8188e_dm.c
drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
drivers/staging/r8188eu/hal/rtl8188e_phycfg.c
drivers/staging/r8188eu/hal/usb_halinit.c
drivers/staging/r8188eu/hal/usb_ops_linux.c
drivers/staging/r8188eu/include/rtw_io.h
drivers/staging/r8188eu/os_dep/ioctl_linux.c