]> git.ipfire.org Git - thirdparty/linux.git/commit
fbdev: of: display_timing: fix refcount leak in of_get_display_timings()
authorWeigang He <geoffreyhe2@gmail.com>
Fri, 16 Jan 2026 09:57:51 +0000 (09:57 +0000)
committerHelge Deller <deller@gmx.de>
Sat, 14 Feb 2026 10:09:46 +0000 (11:09 +0100)
commiteacf9840ae1285a1ef47eb0ce16d786e542bd4d7
treee827a832e2d9497cf2bbaaf454b42036f6b58737
parent88b3b9924337336a31cefbe99a22ed09401be74a
fbdev: of: display_timing: fix refcount leak in of_get_display_timings()

of_parse_phandle() returns a device_node with refcount incremented,
which is stored in 'entry' and then copied to 'native_mode'. When the
error paths at lines 184 or 192 jump to 'entryfail', native_mode's
refcount is not decremented, causing a refcount leak.

Fix this by changing the goto target from 'entryfail' to 'timingfail',
which properly calls of_node_put(native_mode) before cleanup.

Fixes: cc3f414cf2e4 ("video: add of helper for display timings/videomode")
Cc: stable@vger.kernel.org
Signed-off-by: Weigang He <geoffreyhe2@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/of_display_timing.c